Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Include rejected status when we log events. #11008

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Include rejected status when we log events. #11008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c7ab5
Include rejected status when we log events.
richvdh Oct 6, 2021
19bd243
also log the rejection reason
richvdh Oct 18, 2021
062c89c
Merge remote-tracking branch 'origin/develop' into rav/log_rejected
richvdh Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11008.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Include rejected status when we log events.
16 changes: 10 additions & 6 deletions synapse/events/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,12 +348,16 @@ def __str__(self):
return self.__repr__()

def __repr__(self):
return "<%s event_id=%r, type=%r, state_key=%r, outlier=%s>" % (
self.__class__.__name__,
self.event_id,
self.get("type", None),
self.get("state_key", None),
self.internal_metadata.is_outlier(),
rejection = "REJECTED, " if self.rejected_reason else ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a string here I'd be tempted to print it, even if right now its always the same.


return (
f"<{self.__class__.__name__} "
f"{rejection}"
f"event_id={self.event_id}, "
f"type={self.get('type')}, "
f"state_key={self.get('state_key')}, "
f"outlier={self.internal_metadata.is_outlier()}"
">"
)


Expand Down