"Failed to send_join via any server" with "'coroutine' object has no attribute 'event_id'"

[richvdh]

On synapse 1.11.0, when you try to join #synapse:matrix.org, you get:

2020-02-24 14:00:07,320 - synapse.federation.federation_base - 196 - WARNING - POST-1957- Signature check failed for $zTjQbxV26Zs_Jan_Km9kbq7YScafrGYhYMT0rKtJP7o: 403: event id $zTjQbxV26Zs_Jan_Km9kbq7YScafrGYhYMT0rKtJP7o: unable to verify signature for sender matrix.org: 401: Invalid signature for server matrix.org with key ed25519:auto: Unable to verify signature for matrix.org: <class 'nacl.exceptions.BadSignatureError'> Signature was forged or corrupt

and later:

2020-02-24 14:00:10,088 - synapse.federation.federation_client - 421 - WARNING - POST-1957- Failed to send_join via matrix.org
...
Traceback (most recent call last):
  File "/home/synapse/matrixtest/synapse/federation/federation_client.py", line 402, in _try_destination_list
    res = await callback(destination)
  File "/home/synapse/matrixtest/synapse/federation/federation_client.py", line 589, in send_request
    valid_pdus_map = {p.event_id: p for p in valid_pdus}
  File "/home/synapse/matrixtest/synapse/federation/federation_client.py", line 589, in <dictcomp>
    valid_pdus_map = {p.event_id: p for p in valid_pdus}
AttributeError: 'coroutine' object has no attribute 'event_id'
2020-02-24 14:00:10,154 - synapse.http.server - 81 - INFO - POST-1957- <SynapseRequest at 0x7ff1bf3efd30 method='POST' uri='/_matrix/client/r0/join/%23synapse%3Amatrix.org' clientproto='HTTP/1.1' site=8447> SynapseError: 502 - Failed to send_join via any server

[richvdh]

I think there are two problems here:

• $zTjQbxV26Zs_Jan_Km9kbq7YScafrGYhYMT0rKtJP7o has a bad signature; it shouldn't have been accepted by matrix.org.
• something has recently broken the code that is meant to handle the above situation, causing the AttributeError: 'coroutine' object has no attribute 'event_id' error.

[sbug-1bit]

I'm getting this for other rooms.

[MrCustomizer]

This seems also to be reproducible with Fractal's room #fractal-gtk:matrix.org. At least I'm getting the "Failed to send_join via any server"-message when trying to join the room with two different accounts from two different servers.

[sbug-1bit]

#fractal-gtk:matrix.org is one the rooms that don't work for me too.
But also #gridepo:kamax.io and #rust:matrix.org (the rust room I was in, left and tried to rejoin and got that message)

[MrCustomizer]

I just tried the two rooms with one of my accounts and I can't join them either. Always fails with "Failed to send_join via any server".

[clokep]

The attribute error ('coroutine' object has no attribute 'event_id') should be fixed by #6996. @richvdh is this worth keeping open for the signature issue or is that something else?

[richvdh]

I think we should consider the signature warning a separate problem.

[ZLima12]

Currently having this issue. It seems like it was fixed (since it was moved to Done)? If so, would I have to wait until the next release to correct this issue? Or would temporarily running synapse off of master be enough to correct the issue, which would let me go back to stable?