Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

502, 504 (and maybe 503) CONNECT proxy response codes should be treated as though they are direct connection failures #16462

Open
@reivilibre

Description

@reivilibre

offshoot from #15883:

If a 502 or 504 is returned as the status code of the CONNECT verb when proxying, Synapse should treat this as though it tried a connection itself and failed.
It should not log a CRITICAL log line but the same kind of handling as e.g. a connection timeout or refused connection should be used.

We might want to extend support for this to 503 as a kind of quirk given that in #15883 the reporter's proxy software returned 503 instead (this seems incorrect to me but I suppose it'd be worth checking more generally).

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-UncommonMost users are unlikely to come across this or unexpected workflowS-MinorBlocks non-critical functionality, workarounds exist.T-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions