Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Missing validation on typing EDUs #13869

Closed
@squahtx

Description

@squahtx

When we receive a typing EDU from a remote homeserver, we neglect to check that said homeserver is in the room the typing EDU is for.

There was a check that looked like it was doing the job, except it was really checking that the local homeserver is in the room a second time:

domains = await self._storage_controllers.state.get_current_hosts_in_room(
room_id
)
if self.server_name in domains:

related: #11456

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-FederationO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions