Remove undocumented `room_alias` key from `/createRoom` response

[richvdh]

we should either spec this or remove it.

Presumably it exists to save clients the bother of having to construct their own fully-qualified aliases, but given we don't do the same for other endpoints which create aliases, I'm not convinced it is worthwhile.

I'd therefore be in favour of removing it, but it's worth noting that sytest currently uses it in a non-trivial number of places

[turt2live]

I've labelled this as an omission, although I'm not convinced that's the right direction for this particular issue.

[richvdh]

synapse still returns this unspecced field.

[turt2live]

The referenced PR has a bit of a troubled history on this. What are you seeing as an end goal for this issue?

[richvdh]

IMHO we should stop synapse returning the unspecced field.

[ShadowJonathan]

Will that break clients which probably depend on this behaviour? Do such clients exist?

[richvdh]

Will that break clients which probably depend on this behaviour?

yes, of course.

Do such clients exist?

well, that is the $1M question...

[turt2live]

IMHO we should stop synapse returning the unspecced field.

OH. Github mobile said this issue got transferred from synapse to matrix-doc, but on web it's clearly the other way around. This makes sense.