Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Delete local RoomAccessRules module #112

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Nov 10, 2021

The two features implemented by this module now live in https://github.com/vector-im/synapse-room-access-rules and https://github.com/matrix-org/synapse-freeze-room

Note to ops:

To deploy this change, the modules need to be installed in addition to Synapse (from the aforementioned repos, or the PyPI project mentioned in their readmes). The configuration for each individual module doesn't change besides a) being split between two modules and b) needing to be moved to the modules section of the config file, e.g.:

modules:
    - module: freeze_room.FreezeRoom
      config: ...
    - module: room_access_rules.RoomAccessRules
      config: ...

@babolivier babolivier requested a review from a team November 10, 2021 16:37
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this deletes only files which aren't in mainline Synapse. I believe the modules were already checked to ensure they implement the same behavior.

@babolivier babolivier merged commit 29168d8 into dinsic Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants