-
-
Notifications
You must be signed in to change notification settings - Fork 117
MSC4133: Update profile endpoints to support extended fields #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tcpipuk
wants to merge
34
commits into
matrix-org:main
Choose a base branch
from
tcpipuk:MSC4133
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fdc012a
Describe MSC4133 profile endpoint changes
tcpipuk 212377e
Merge branch 'matrix-org:main' into MSC4133
tcpipuk 1fc0118
2071 change log
tcpipuk b2e122f
Update changelog from `clarification` to `feature`
tcpipuk 59d2c62
Link to MSC4133 in endpoint descriptions
tcpipuk ee9b5dd
Correct types and errors
tcpipuk 8e9874a
Simplify change log
tcpipuk 41c64c8
Linkify MSC4133 in change log
tcpipuk 82adcec
Clarify `avatar_url` should be MXC
tcpipuk 4f8999b
Tweak wording on full profile `GET`
tcpipuk 992cf9d
Clarify `null` behaviour for `PUT` and `DELETE`
tcpipuk 3311b08
Alphabetise `avatar_url` and `displayname` and remove redundant descr…
tcpipuk f3c269d
Added capability
tcpipuk 9327793
Inline information from MSC4133, remove links
tcpipuk 5d5b561
Deprecate `m.set_displayname` and `m.set_avatar_url` capabilities
tcpipuk 76b48e2
Specify CNIG pattern for custom fields
tcpipuk 79a1cde
Remove reference to spec version in `m.profile_field` capability
tcpipuk 17af55d
Fix broken link
tcpipuk 79af780
Camel case for endpoint variables
tcpipuk 1cc93ec
Attempt to make descriptions look better in HTML rendered spec
tcpipuk 0b0942d
Clarify capability lists should support wildcards
tcpipuk 7a3b0c0
Clarify in change log that `m.set_avatar_url` and `m.set_displayname`…
tcpipuk 9859e20
Don't use reference for capability.
tcpipuk 013502b
Mention replacement for `m.set_displayname` and `m.set_avatar_url` ca…
tcpipuk 9889fe3
Use more accessible terminology than "glob"
tcpipuk 3a5e555
Correct `PUT`/`GET` payload definitions
tcpipuk 7ef1d9d
Add `x-changedInMatrixVersion`
tcpipuk b5e2edf
Add `x-addedInMatrixVersion`
tcpipuk d8cc250
Tag `x-addedInMatrixVersion` on `additionalProperties` in entire prof…
tcpipuk 37b1362
Attempt to describe variable payload content
tcpipuk 50eab35
Standardise line-wrapping and update `avatar_url` format to `mx-mxc-uri`
tcpipuk dd4ea94
Clarify why `avatar_url` and `displayname` can't be returned as `null`
tcpipuk 6183f24
Clarify value validation requirements
tcpipuk 6646146
Accept minor suggestions from code review
clokep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Feature: Update profile endpoints to become generic to support MSC4133 extended fields. Stabilised keys (e.g. "displayname" and "avatar_url") are explicitly enumerated, and custom keys must conform to the Common Namespaced Identifier Grammar. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.