-
Notifications
You must be signed in to change notification settings - Fork 399
MSC4293: Redact on ban #4293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MSC4293: Redact on ban #4293
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,117 @@ | ||
# MSC4293: Redact on ban | ||
|
||
[MSC2244 (accepted)](https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/2244-mass-redactions.md)-style | ||
mass redactions are incredibly helpful for cleaning up large volumes of spam, but still require sending | ||
a dedicated event to clean up the spam. In a typical case, a user will get kicked/banned from a room | ||
and the moderators will further redact some or all of their messages. Mass redactions have more use | ||
cases, but the specific case of "redact everything upon ban" is something which may be easily backported | ||
to existing room versions. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think I'm quite getting this proposal. So it's just a temporary measure to do mass redactions in old room versions? Why not just a separate 'mass redact' endpoint? Or, for that matter, have the HS look for mass redact events sent into old room versions and do them manually exactly as it would do here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. MSC4194 is a prior exploration of a mass redact endpoint for this use case. A reason for collecting the responsibilities into a flag on the ban event are because of the following complications:
Footnotes
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As Gnuxie mentions, we can't/shouldn't be sending 1:1 redaction events anymore, especially post-ban (the original sender can't "self-redact", and the moderator who did the ban may have left). This MSC specifically tries to reduce the number of redaction events to zero if it can, or one in the worst case - mass redactions themselves would be the "one" case. The issue with mass redact events is that they aren't backwards compatible to existing room versions, which will cause breakage. We could spend some time trying to fix this (fallback fields, different event types, etc), but those solutions don't look as great (in my opinion) and slow down the rollout of the feature due to broader use cases needing consideration. We (T&S) expect that both redact-on-ban and mass redactions will be used in future room versions concurrently for different use cases, and require a more immediate solution to 1:1 redaction event sending. I'll cover this in the alternatives section when I loop back around for an edit. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm afraid I may be more confused if anything. I was assuming the HS would do something to make this backwards compatible but now I wonder if I've misunderstood that. What makes this backwards compatible given a mass redaction isn't? If this is not a short-term measure, in what circumstances would this be used vs a mass redaction? In any case, hopefully the edit should make things clearer. The info in the responses here probably needs to go into the MSC. |
||
|
||
This proposal suggests adding a new flag to membership events to indicate to clients and servers that | ||
all of that user's events should be redacted in addition to being kicked or banned. The flag isn't | ||
protected from redaction itself, so may have some consistency issues, but overall should still provide | ||
relatively high amounts of protection to rooms. | ||
|
||
This proposal is exploratory and subject to change. Implementations may validate the idea through | ||
early feature support, but MUST expect that things will change (or become completely rejected). | ||
|
||
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
|
||
## Proposal | ||
|
||
A new flag is added to [`m.room.member`](https://spec.matrix.org/v1.14/client-server-api/#mroommember) | ||
events where the target user is kicked or banned (**TODO**: Allow on self-leaves too?): `redact_events`. | ||
This flag is a boolean and, when `true`, causes servers (and clients) to redact all of the user's events | ||
as though they received an [`m.room.redaction`](https://spec.matrix.org/v1.14/client-server-api/#mroomredaction), | ||
including adding [`redacted_because`](https://spec.matrix.org/v1.14/client-server-api/#redactions) to | ||
`unsigned` where applicable. An `m.room.redaction` event is not actually sent, however. | ||
|
||
**Note**: This also means that if the user was kicked/banned with a `reason`, that event is automatically | ||
compatible with the redaction `reason` field and shows up accordingly. | ||
|
||
Similar to regular redactions, if the sender of the membership event can't actually redact the target's | ||
events, the redaction doesn't apply. This means having a power level higher than or equal to `redacts` | ||
*and* `events["m.room.redaction"]` (if set). Normally, `m.room.redaction` events could be rejected | ||
due to the power levels - that rejection behaviour doesn't apply with the `redact_events` field. | ||
Instead, the target's events are simply not redacted. | ||
|
||
If the sender is allowed to redact, the redaction behaviour continues until the membership event itself | ||
is redacted (thus removing the field) or another membership event removes the field. For example, if | ||
the user is unbanned, the moderator MAY NOT choose to carry the `redact_events` flag to that kick | ||
(unban) event. Or, when the user rejoins after a kick, the flag is implicitly dropped. | ||
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Events which are delivered after the ban are likely [soft failed](https://spec.matrix.org/v1.14/server-server-api/#soft-failure) | ||
and are still redacted if the current membership event in the room has a valid `redact_events` | ||
field. | ||
|
||
Other membership states with the flag no-op, such as joins, knocks, and invites. | ||
|
||
Moderation bots and similar MAY still wish to issue (mass) redactions upon kick/ban to protect users | ||
on servers or clients which don't have this feature. | ||
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Example ban: | ||
|
||
```jsonc | ||
{ | ||
// Irrelevant fields excluded | ||
"type": "m.room.member", | ||
"state_key": "@spam:example.org", | ||
"sender": "@mod:example.org", | ||
"content": { | ||
"membership": "ban", | ||
"reason": "flooding", // this is copied to `redacted_because`, leading to clients showing it | ||
"redact_events": true | ||
} | ||
} | ||
``` | ||
|
||
The new field is proxied through to the event by the [`/kick`](https://spec.matrix.org/v1.14/client-server-api/#post_matrixclientv3roomsroomidkick) | ||
and [`/ban`](https://spec.matrix.org/v1.14/client-server-api/#post_matrixclientv3roomsroomidban) | ||
sugar APIs, like `reason` is. | ||
|
||
## Potential issues | ||
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't this potentially have weird behavior if a server redacts the events, redacts the membership event itself, then backfills events? It is unclear to me if this is covered the text below (or above in fallback behavior?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it should be covered in the potential issues, but I'll aim to clarify in the text. The short version is: yes, it's weird, but not any more weird than usual. A server which requests events from a server that redacted them will receive redacted copies. This infectious behaviour is a feature, though if a server really wanted to it could ask other servers until it finds an unredacted copy. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm worried about the opposite -- receiving unredacted events and not knowing they should be redacted. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That should already be addressed in the MSC, as a known limitation. |
||
|
||
It's a little annoying that the flag is redacted when the membership event is redacted, however it's | ||
extremely rare for a moderator/admin to redact a kick or ban event. This can be fixed in a future | ||
room version, like what is proposed by [MSC4298](https://github.com/matrix-org/matrix-spec-proposals/pull/4298). | ||
|
||
Though extremely rare, if an existing server in the room didn't apply the redactions *and* a sender's | ||
ban was redacted, a new server to the room may backfill through that existing server and see unredacted | ||
events without knowing it's supposed to redact them due to the ban having lost the `redact_events` | ||
field. This is fixed for future room versions by implementing something like [MSC4298](https://github.com/matrix-org/matrix-spec-proposals/pull/4298). | ||
|
||
Clients may miss the membership event if they are using lazy loading, though servers should already | ||
be tracking which membership events the client has received and needs to render events in the timeline. | ||
This should mean that those clients will still receive the event. | ||
|
||
Servers which miss the event will eventually receive or retrieve it, just like they would with any | ||
other event. | ||
|
||
## Alternatives | ||
|
||
Mass redactions are the cited major alternative, where a single event can target approximately 1500 | ||
other events in the room. New rooms can benefit from that functionality, especially for cases not | ||
covered by this proposal, while existing rooms can be given an option to protect their users with | ||
relative ease. | ||
|
||
## Security considerations | ||
turt2live marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
As the room moderator/administrator would already send redactions, and may still for full protection, | ||
it's not deemed any more risk than today. This may change if self-leaves are permitted to also carry | ||
the field. | ||
|
||
There may also be implementation or reliability bugs which inhibit the "stop redacting now" point | ||
from working as intended. Server implementations in particular should ensure that an event received | ||
after a membership event which asks for redaction is *really* affected by that redaction. ie: whether | ||
it's just a late delivery, or if there's a join waiting for state res to make a determination. | ||
|
||
## Unstable prefix | ||
|
||
While this proposal is not considered stable, implementations should use `org.matrix.msc4293.redact_events` | ||
instead of `redact_events`. | ||
|
||
## Dependencies | ||
|
||
This MSC has no direct dependencies. | ||
|
||
## Credits | ||
|
||
Credit goes to Erik of the Spec Core Team for the suggestion to look into this. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation requirements:
Other non-qualifying (as of writing) implementations: