-
Notifications
You must be signed in to change notification settings - Fork 399
MSC3816: Clarify Thread Participation #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# MSC3816: Clarify Thread Participation | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is probably worth mentioning that this spawned from a conversation on MSC3772: #3772 (comment) |
||
|
||
[MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) defines relations | ||
for threads and includes a `current_user_participated` flag, which is not fully | ||
defined: | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
> A flag set to `true` if the current logged in user has participated in the thread | ||
|
||
Known implementations implement this as whether the currently logged in user has | ||
sent an event with an `m.thread` relation targeting the event, but this does not | ||
make sense if the requesting user was the original event in the thread. | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Consider `A` as the root event in a thread from `@alice:example.com`, and `B` | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
as a threaded reply from `@bob:example.com`. The bundled aggregations for `A` | ||
would include: | ||
|
||
| Requester | `current_user_participated` | | ||
|----------------------|-----------------------------| | ||
| `@alice:example.com` | `false` | | ||
| `@bob:example.com` | `true` | | ||
|
||
If `@alice:example.com` sends reply `C`, this would change: | ||
|
||
| Requester | `current_user_participated` | | ||
|----------------------|-----------------------------| | ||
| `@alice:example.com` | `true` | | ||
| `@bob:example.com` | `true` | | ||
|
||
The proposed clarification is that `@alice:example.com` should have always have | ||
participated in the thread (e.g. both tables would be `true` in the example above). | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Proposal | ||
|
||
The [definition of the `current_user_participated` flag](https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3440-threading-via-relations.md#event-format) | ||
from the bundled aggregations for `m.thread` relations is updated: | ||
|
||
> A boolean flag, which is set to `true` if the current logged in user has | ||
> participated in the thread. The user has participated if: | ||
> | ||
> * They created the current event. | ||
> * They created an event with a `m.thread` relation targeting the current event. | ||
|
||
This better matches the intention of this flag, which is that a client is able to | ||
visually separate threads which might be of interest. | ||
|
||
## Potential issues | ||
|
||
The current implementations will need to be updated to take into account the | ||
sender of the current event when generating bundled aggregations. This should be | ||
trivial since all of the needed information is directly available. | ||
|
||
It is suggested to [the new `filter` parameters from MSC3440](https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/3440-threading-via-relations.md#fetch-all-threads-in-a-room) | ||
clokep marked this conversation as resolved.
Show resolved
Hide resolved
|
||
in order to list threads in a room that a user has participated in. There would | ||
now be an inconsistency that threads where the current user sent the root event | ||
but has not replied to the thread could not easily be fetched. A future MSC may | ||
solve this problem. | ||
|
||
## Alternatives | ||
|
||
Do not clarify [MSC3440](https://github.com/matrix-org/matrix-spec-proposals/pull/3440) | ||
and leave it up to implementations to define the behavior of the | ||
`current_user_participated` flag. | ||
|
||
## Security considerations | ||
|
||
None | ||
|
||
## Unstable prefix | ||
|
||
None, the changes above shouldn't dramatically change behavior for clients. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.