Skip to content

Add an unstable room version to MSC2174 #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2022
Merged

Add an unstable room version to MSC2174 #3788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bdb47c
Add an unstable room version to MSC2174
turt2live May 4, 2022
f12d6b5
Associate room version
turt2live May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions proposals/2174-move-redacts-key.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,9 @@ when serving such events over the Client-Server API.
For improved compatibility with *newer* clients, servers should add a `redacts`
property to the `content` of `m.room.redaction` events in *older* room versions
when serving such events over the Client-Server API.

## Unstable prefix

Implementations should use `org.matrix.msc2174` for the room version containing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't matter much, but does anything actually use this room version? The synapse impl. seems to bundle msc2174 and msc2176 together into org.matrix.msc2176

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That implementation is actually incomplete :D

At a glance, it looks like the implementation was missing the bit where the key moved into content, but I guess if that's been done then there's no real need for a specific room version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It ended up needing a room version: matrix-org/synapse#12634

this change until assigned to a specified room version. That room version should
use room version 6 as a base.