-
Notifications
You must be signed in to change notification settings - Fork 399
MSC3283: Expose capabilities for profile actions #3283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e04ae30
Create 3278-enable_set_displayname-capabilities.md
JonasKress 0fd7c94
Apply suggestions from code review
JonasKress c711706
Apply suggestions from code review
JonasKress 7291992
Update and rename 3278-enable_set_displayname-capabilities.md to 3279…
JonasKress 9c8fec0
Update and rename 3279-enable_set_displayname-capabilities.md to 3282…
JonasKress 53ffb61
Update and rename 3282-enable_set_displayname-capabilities.md to 3283…
JonasKress ab5ceb0
Update proposals/3283-enable_set_displayname-capabilities.md
JonasKress d9fcd0e
Update proposals/3283-enable_set_displayname-capabilities.md
JonasKress 0fa212f
Update proposals/3283-enable_set_displayname-capabilities.md
JonasKress 9d3a2a4
Update 3283-enable_set_displayname-capabilities.md
JonasKress c48cb3c
Update 3283-enable_set_displayname-capabilities.md
JonasKress 05c24f6
Update proposals/3283-enable_set_displayname-capabilities.md
JonasKress af09113
Update proposals/3283-enable_set_displayname-capabilities.md
JonasKress ad7c017
Update 3283-enable_set_displayname-capabilities.md
JonasKress 0368523
Update 3283-enable_set_displayname-capabilities.md
JonasKress 057d341
Update 3283-enable_set_displayname-capabilities.md
JonasKress cad9619
Update 3283-enable_set_displayname-capabilities.md
JonasKress File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# MSC3283: Expose enable_set_displayname in capabilities response | ||
|
||
|
||
Some home servers like synapse can be configured to enable_set_displayname: false. To enable clients to handle that gracefully in the UI this setting should be exposed. | ||
JonasKress marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Proposal | ||
|
||
The `/_matrix/client/r0/capabilities` endpoint could be decorated to provide more information on capabilities. | ||
JonasKress marked this conversation as resolved.
Show resolved
Hide resolved
|
||
```javascript | ||
JonasKress marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{ | ||
"capabilities": { | ||
"m.enable_set_displayname": false, | ||
JonasKress marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"m.room_versions": {...}, | ||
} | ||
} | ||
``` | ||
As part of this MSC, a capability will be added that exposes the server setting: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not actually clear from this MSC whether clients should check this when exposing controls to set the profile, or to set the displayname in a member event, or both? I'd prefer something like |
||
`m.enable_set_displayname` | ||
|
||
## Client recommendations | ||
When presenting profile settings, clients should use capabilities in order to display the correct UI. | ||
If capability is not present the default is true. | ||
JonasKress marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Unstable prefix | ||
Implementations won't actually be able to use m.enable_set_displayname until the MSC has finished the Final Comment Period. While the MSC is in review, implementations can use an unstable prefix (im.vector.enable_set_displayname) instead. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.