-
Notifications
You must be signed in to change notification settings - Fork 399
MSC2610: Remove m.login.oauth2
User-Interactive Authentication type from the specification
#2610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# MSC2610: Remove `m.login.oauth2` User-Interactive Authentication type from the specification | ||
|
||
The client-server API specification | ||
[defines](https://matrix.org/docs/spec/client_server/r0.6.1#authentication-types) | ||
a number of "authentication types" for use with the User-Interactive | ||
Authentication protocol. | ||
|
||
Of these, `m.login.oauth2` is underspecified and of no | ||
real use. This MSC proposes removing them. | ||
|
||
## Proposal | ||
|
||
The definition of | ||
[OAuth2-based](https://matrix.org/docs/spec/client_server/r0.6.1#oauth2-based) | ||
authentication is incomplete. [OAuth2](https://oauth.net/2/) is best considered | ||
as a framework for implementing authentication protocols rather than a protocol | ||
in its own right, and this section says nothing about the grant types, flows | ||
and scopes which a compliant implemenation should understand. | ||
|
||
A better candidate for OAuth2-based authentication of matrix clients is via | ||
[OpenID Connect](https://openid.net/connect/), but this has already been | ||
implemented in Matrix via the `m.login.sso` authentication type. | ||
|
||
The `m.login.oauth2` section is therefore unimplementable in its current form, | ||
and redundant. It should be removed from the specification to reduce confusion. | ||
|
||
## Alternatives | ||
|
||
It would be possible to extend the definition so that it is complete: as | ||
mentioned above, a likely implemenation would be based on OpenID | ||
richvdh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Connect. Matrix clients could then follow the standardised OpenID Connect flow | ||
rather than the matrix-specific `m.login.sso` flow. However, this would require | ||
significant design work, and development in both clients and servers, which | ||
currently feels hard to justify when a working solution exists via | ||
`m.login.sso`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.