Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(sdk): Move matrix_auth and oidc into the authentication module #4575

Merged
merged 3 commits into from
Jan 22, 2025
Merged

refactor(sdk): Move matrix_auth and oidc into the authentication module #4575

merged 3 commits into from
Jan 22, 2025

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jan 22, 2025 •
edited
Loading

matrix_auth is renamed to matrix in the process since the auth is for "authentication".

  • Public API changes documented in changelogs (optional)

@zecakeh zecakeh requested a review from a team as a code owner January 22, 2025 16:13
@zecakeh zecakeh requested review from Hywan and removed request for a team January 22, 2025 16:13
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (a528624) to head (4590fe7).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4575   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         285      285           
  Lines       32222    32222           
=======================================
  Hits        27525    27525           
  Misses       4697     4697

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

poljar
poljar requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you please just remove the TODO I linked previously?

matrix-rust-sdk/crates/matrix-sdk/src/authentication/mod.rs

Line 18 in 1d83d42

// TODO:(poljar) Move the oidc and matrix_auth modules under this module.

@poljar poljar removed the request for review from Hywan January 22, 2025 19:11
@zecakeh
Copy link
Collaborator Author

zecakeh commented Jan 22, 2025

I removed it already.

poljar
poljar approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah indeed, how did I miss that.

@poljar poljar merged commit df51404 into matrix-org:main Jan 22, 2025
40 checks passed
@zecakeh zecakeh deleted the move-auth branch January 22, 2025 19:34
@pixlwave pixlwave mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poljar poljar poljar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zecakeh @poljar