refactor(sdk,ui): Remove RoomEventCacheUpdate::AddTimelineItems
#4462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
chore-ui-timeline-cleanup
branch
2 times, most recently
from
199ec3d to
cdb287b
Compare
This was referenced Jan 8, 2025
`owned_user_id` is only used by a test behind the `experimental-sliding-sync` feature flag.
Hywan
force-pushed
the
chore-ui-timeline-cleanup
branch
2 times, most recently
from
5681b4e to
59afd8b
Compare
This patch removes the `AddTimelineEvents` variant from `RoomEventCacheUpdate` since it is replaced by `UpdateTimelineEvents` which shares `VectorDiff`. This patch also tests all uses of `UpdateTimelineEvents` in existing tests.
From now on, this patch considers that `VectorDiff`s are the official input type for the `Timeline`, via `RoomEventCacheUpdate` (notably `::UpdateTimelineEvents`). This patch removes `TimelineSettings::vectordiffs_as_inputs`. It thus removes all deduplication logics, as it is supposed to be managed by the `EventCache` itself.
Hywan
force-pushed
the
chore-ui-timeline-cleanup
branch
from
59afd8b to
ba57d99
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4462 +/- ##
==========================================
+ Coverage 85.11% 85.32% +0.20%
==========================================
Files 283 283
Lines 31790 31727 -63
==========================================
+ Hits 27059 27071 +12
+ Misses 4731 4656 -75 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR has introduced
RoomEventCacheUpdate::UpdateTimelineEvents, see #4408. The reasons to add a variant instead of updatingAddTimelineItemswere the following:But now it's time for the clean up! We have to remove the
AddTimelineItemsvariant first, and then to remove theTimelineSettings::vectordiffs_as_inputssettings. Many tests have to be updated, and that's the majority of the changes brought by these patches.Tasks:
RoomEventCacheUpdate::AddTimelineItemsTimelineSettings::vectordiffs_as_inputsEventCachestorage #3280