feat: Implement App API
#2204
feat: Implement App API
#2204
Conversation
crates/matrix-sdk-ui/src/app/mod.rs
Outdated
| self | ||
| } | ||
|
|
||
| pub fn with_encryption_sync(mut self) -> Self { |
There was a problem hiding this comment.
As mentioned in the Matrix room, do we need this? Can't we make it always true?
There was a problem hiding this comment.
I think that's needed until we enable the encryption sync by default... which should be the case any time now.
There was a problem hiding this comment.
Alright, once we do that, please let us remove this as well.
|
|
||
| pub struct App { | ||
| room_list: Arc<RoomListService>, | ||
| encryption_sync: Option<Arc<EncryptionSync>>, |
There was a problem hiding this comment.
If we're always going to have an EncryptionSync then we don't need an optional here. We could #[cfg(feature = "e2e-encryption")] this field if we want to support clients that don't use E2EE.
| // and the loop to terminate. | ||
|
|
||
| loop { | ||
| tokio::select! { |
bnjbvr
force-pushed
the
better-get-notification-api
branch
from
8e286f9 to
a24495a
Compare
bnjbvr
changed the title
App and NotificationClient APIsApp API
|
Tested and works pretty well on the iOS side, makes the code easier to read a decouples a lot of responsibilities from the client, love it! |
bnjbvr
force-pushed
the
better-get-notification-api
branch
from
a24495a to
cc92444
Compare
bnjbvr
requested review from
jplatte and
poljar
and removed request for
a team and
jplatte
|
Thanks a bunch Mauro for trying it 🥳 This is now ready for review, since the I still am not fond of the |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
- Coverage 76.73% 76.64% -0.09%
==========================================
Files 172 173 +1
Lines 18060 18081 +21
==========================================
Hits 13858 13858
- Misses 4202 4223 +21
☔ View full report in Codecov by Sentry. |
This implements a very high-level
AppAPI that takes care of all the sliding syncs:with_encryption_sync, then it will spawn two sliding syncs, one for the room list, one for e2ee. It can be configured to run with the cross-process crypto store lock or not (for the needs of Element X iOS).Fixes #1928.
This is based on top of #2235, as the final commits get rid of ways to manually create (and misconfigure)
EncryptionSyncand theRoomListService\o/