This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Convert enzyme to rtl: BeaconMarker #9840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 28, 2022 16:09
artcodespace
added
the
T-Task
| }); | ||
|
|
||
| it("updates with new locations", () => { | ||
| // we need to mock the SmartMarker here to be able to check the geoUris | ||
| const uriSmartMarker = jest.spyOn(mockSmartMarker, "default"); | ||
| uriSmartMarker.mockImplementation((props) => <div data-testid={props.geoUri} />); |
There was a problem hiding this comment.
Could you spy on maplibregl.Marker.setLngLat to assert the uri is updated instead of this? Similar to how the SmartMarker tests work?
There was a problem hiding this comment.
I'll have a look at that, thanks for the suggestion. It didn't feel good doing this and I'm in a similar scenario trying to rewrite another test
kerryarchibald
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts enzyme to rtl. The final test has some reasonably aggressive mocking in it to try and keep the sense of the enzyme test it replaces, there may be a better way to do this
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.