This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Refactor + improve test coverage for QR login #9525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughns
added
the
T-Task
hughns
force-pushed
the
hughns/qr-login-tests
branch
from
c4664d8 to
bb60dd1
Compare
duxovni
approved these changes
Nov 1, 2022
| cancellationMessage = _t("An unexpected error occurred."); | ||
| break; | ||
| case RendezvousFailureReason.HomeserverLacksSupport: | ||
| cancellationMessage = _t("The homeserver doesn't support signing in another device."); |
There was a problem hiding this comment.
Suggested change
| cancellationMessage = _t("The homeserver doesn't support signing in another device."); | |
| cancellationMessage = _t("The homeserver doesn't support using a device to sign in another device."); |
(As written, it sounds like you're not allowed to have more devices on your account at all.)
There was a problem hiding this comment.
Good point. I've fed this into a design review which is in-flight. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves element-hq/element-web#23549
This PR includes a refactor to provide greater separation between UI and logic.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.