Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Add additional metadata to feedback submitted through spotlight dialog #9024

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Add additional metadata to feedback submitted through spotlight dialog #9024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb0cdd5
Add additional metadata to feedback submitted through spotlight dialog
justjanne Jun 28, 2022
29de8a8
Merge branch 'develop' into justjanne/task/add-metadata-to-spotlight-…
justjanne Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/views/dialogs/FeedbackDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ const existingIssuesUrl = "https://github.com/vector-im/element-web/issues" +
"?q=is%3Aopen+is%3Aissue+sort%3Areactions-%2B1-desc";
const newIssueUrl = "https://github.com/vector-im/element-web/issues/new/choose";

interface IProps extends IDialogProps {}
interface IProps extends IDialogProps {
feature?: string;
}

const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const feedbackRef = useRef<Field>();
Expand All @@ -55,7 +57,8 @@ const FeedbackDialog: React.FC<IProps> = (props: IProps) => {
const onFinished = (sendFeedback: boolean): void => {
if (hasFeedback && sendFeedback) {
if (rageshakeUrl) {
submitFeedback(rageshakeUrl, "feedback", comment, canContact);
const label = props.feature ? `${props.feature}-feedback` : "feedback";
submitFeedback(rageshakeUrl, label, comment, canContact);
}

Modal.createDialog(InfoDialog, {
Expand Down
4 changes: 3 additions & 1 deletion src/components/views/dialogs/spotlight/SpotlightDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,9 @@ const SpotlightDialog: React.FC<IProps> = ({ initialText = "", initialFilter = n
};

const openFeedback = SdkConfig.get().bug_report_endpoint_url ? () => {
Modal.createDialog(FeedbackDialog);
Modal.createDialog(FeedbackDialog, {
feature: "spotlight",
});
} : null;

const activeDescendant = rovingContext.state.activeRef?.current?.id;
Expand Down