This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Use cached value to read member count #6429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Jul 21, 2021
t3chguy
approved these changes
Jul 21, 2021
t3chguy
reviewed
Jul 21, 2021
Comment on lines
+282
to
+284
| private calculateRoomMembersCount = (): void => { | ||
| this.membersCount = this.props.room?.getMembers().length || 0; | ||
| }; |
There was a problem hiding this comment.
this doesn't setState so will have a very jarring update behaviour, it'll take effect the render after this fires, weirdly laggy. I don't think this is the right solution and think it does not whatsoever match what I accepted in review. @gsouquet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#18146
Needs matrix-org/matrix-js-sdk#1803