-
-
Notifications
You must be signed in to change notification settings - Fork 824
Conversation
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
dd39fea
to
b5c24c6
Compare
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing left is that SettingsStore.getValue("feature_video_rooms")
needs to apply not only to the settings button but to the feature as a whole, so if you enable the metaspace then turn off the labs flag it needs to also be shut off
This is what I am doing here: https://github.com/matrix-org/matrix-react-sdk/pull/12297/files#diff-784fdffdccd4851b6d0561513eb9d6017643a69a3fa52aa3865b4b2b03a3e29cR159-R174 I am filtering the metaspace element from the dictionary before applying rendering the space components. Or are you thinking about a different way to shut off the feature. |
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K [email protected]
Checklist