Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Video call meta space #12297

Merged
merged 35 commits into from
Mar 25, 2024
Merged

Video call meta space #12297

merged 35 commits into from
Mar 25, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Feb 29, 2024

Signed-off-by: Timo K [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

@toger5 toger5 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 29, 2024
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
@toger5 toger5 requested a review from t3chguy March 13, 2024 15:39
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing left is that SettingsStore.getValue("feature_video_rooms") needs to apply not only to the settings button but to the feature as a whole, so if you enable the metaspace then turn off the labs flag it needs to also be shut off

@t3chguy t3chguy removed the request for review from a team March 15, 2024 18:54
@toger5
Copy link
Contributor Author

toger5 commented Mar 15, 2024

I think the only thing left is that SettingsStore.getValue("feature_video_rooms") needs to apply not only to the settings button but to the feature as a whole, so if you enable the metaspace then turn off the labs flag it needs to also be shut off

This is what I am doing here: https://github.com/matrix-org/matrix-react-sdk/pull/12297/files#diff-784fdffdccd4851b6d0561513eb9d6017643a69a3fa52aa3865b4b2b03a3e29cR159-R174

and here: https://github.com/matrix-org/matrix-react-sdk/pull/12297/files#diff-c8e2991977b39b4cc5e2eb695ba3c641959d0876fed7de250a14e92e120fb1cdR297-R302

I am filtering the metaspace element from the dictionary before applying rendering the space components.

Or are you thinking about a different way to shut off the feature.
Now it just does not have any impact anymore since the video meta space will never be active. We still store the configuration if it should be shown when activated however?

Signed-off-by: Timo K <[email protected]>
@toger5 toger5 added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit a24aa7e Mar 25, 2024
26 checks passed
@toger5 toger5 deleted the toger5/video-call-meta-space branch March 25, 2024 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants