This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Kill off references to deprecated getStoredDevice and getStoredDevicesForUser
#11152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix-org/matrix-js-sdk#3514 deprecates `CryptoEvent.VerificationRequest` in favour of `CryptoEvent.VerificationRequestReceived`. Use the new event.
richvdh
added
the
T-Task
richvdh
force-pushed
the
rav/element-r/30_kill_get_stored_device
branch
from
43cc2b2 to
e065f7e
Compare
I seem to be writing this logic several times, so let's factor it out.
Another utility function
richvdh
force-pushed
the
rav/element-r/30_kill_get_stored_device
branch
from
e065f7e to
5621e30
Compare
richvdh
requested review from
germain-gg and
SimonBrandner
and removed request for
a team
Base automatically changed from
rav/element-r/29_verification_request_received_event
to
develop
June 28, 2023 10:58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods have been deprecated in the js-sdk, and don't work with rust crypto, so switch to their replacements.
Review commit-by-commit. Based on #11141.
This change is marked as an internal change (Task), so will not be included in the changelog.