This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix flaky Percy tests of ReplyChain
#10450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
- Add media query for percy on _ReplyChain.pcss to apply the same color to vertical strokes (border-left)of ReplyChain - Use CSS variables for visibility - Manage those variables on _common.pcss for maintainability Signed-off-by: Suguru Hirahara <[email protected]>
3 tasks
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
luixxiul
changed the title
ReplyChain
andybalaam
added
the
X-Needs-Percy
andybalaam
approved these changes
Mar 27, 2023
|
The border color issue seems to have been fixed (
I guess it is because the declaration "list-style-type: none" of It can be seen on another test as well.
Adding a commit which should fix the issue. |
Signed-off-by: Suguru Hirahara <[email protected]>
|
Percy snapshots look reasonable, so I think this leaves us in a better state than we were in before. |
|
Thanks for the review! The previous commit failed to fix the list style issue. I'm going to create an issue for it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#24881
This PR intends to address the flaky Percy snapshot tests of
ReplyChainby applying a media query for Percy.Here is the list of the snapshots which should be addressed with this PR:
EventTile with reply chains on modern layoutEventTile with reply chains on compact modern layoutEventTile with reply chains on IRC layoutEventTile with reply chains on bubble layoutThis PR also adds another step to check whether a sent receipt is rendered, so snapshots should capture the receipt consistently, mitigating the risk of flakiness.
For a reviewer: before merging, please add
X-Needs-Percyto check whether the strokes color and the profile name color is same ($username-variant1-color, which is#368bd6on light theme).type: task
Signed-off-by: Suguru Hirahara [email protected]
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.