-
-
Notifications
You must be signed in to change notification settings - Fork 618
Add reportRoom API #4753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reportRoom API #4753
Conversation
The SDK claims it doesn't support 1.13 yet: https://github.com/matrix-org/matrix-js-sdk/blob/develop/src/version-support.ts#L26 |
There are certainly elements of 1.10+ supported in this SDK, so what's the procedure for it? Should I put a docstring in warning that it's only partially supported? |
Definitely worth mentioning the Matrix version requirement in the typedoc IMO, as the error from the server in such a case won't be helpful, likely a 404 M_UNRECOGNIZED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this is fine: saying that we support an certain API version is saying we support all of it, we can still support bits of newer versions. We generally have not done any kind of version checking on news APIs like this since if it's not there, it will just fail anyway.
This arrived in Matrix 1.13 https://spec.matrix.org/latest/client-server-api/#post_matrixclientv3roomsroomidreport
Checklist
public
/exported
symbols have accurate TSDoc documentation.