Skip to content

Remove deprecated methods and fields #4201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2024
Merged

Remove deprecated methods and fields #4201

merged 6 commits into from
May 15, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 15, 2024

Requires matrix-org/matrix-react-sdk#12524

  • Removes threepidCreds on EmailIdentityDict - should use threepid_creds
  • Removes Room::shouldUpgradeToVersion - should use Room::getRecommendedVersion instead
  • Removes user field on UIA calls, uses identifier instead
  • Removes address field on Login request interface - should use identifier instead
  • Removes IEncryptedFile - should use EncryptedFile on types export instead
  • Removes ICrossSigningKey - should use CrossSigningKeyInfo
  • Removes IJoinRuleEventContent - should use RoomJoinRulesEventContent
  • Removes home_server field on RegisterResponse - should derive from user_id by splitting at the first colon instead

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy changed the title Remove legacy threepidCreds field Remove deprecated methods May 15, 2024
@t3chguy t3chguy changed the title Remove deprecated methods Remove deprecated methods and fields May 15, 2024
@t3chguy t3chguy added X-Breaking-Change T-Deprecation A pull request that makes something deprecated labels May 15, 2024
t3chguy added 5 commits May 15, 2024 09:46
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review May 15, 2024 09:40
@t3chguy t3chguy requested review from a team as code owners May 15, 2024 09:40
@t3chguy t3chguy requested review from uhoreg, richvdh and robintown May 15, 2024 09:40
@t3chguy t3chguy self-assigned this May 15, 2024
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving it

@t3chguy t3chguy added this pull request to the merge queue May 15, 2024
Merged via the queue into develop with commit f03dd7b May 15, 2024
27 checks passed
@t3chguy t3chguy deleted the t3chguy/threepidCreds branch May 15, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Deprecation A pull request that makes something deprecated X-Breaking-Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants