Skip to content

Fix "mark_skipped" action for end-to-end tests #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Dec 5, 2023

This seems to have been broken by #3914, which changed the name of the status check that is updated.


This change is marked as an internal change (Task), so will not be included in the changelog.

This seems to have been broken by
#3914, which changed the name
of the status check that is updated.
@richvdh richvdh requested a review from a team as a code owner December 5, 2023 17:53
@richvdh richvdh requested a review from MidhunSureshR December 5, 2023 17:53
@richvdh richvdh added the T-Task Tasks for the team like planning label Dec 5, 2023
@richvdh
Copy link
Member Author

richvdh commented Dec 5, 2023

(Note that the name of the status check will still be different to the one we're currently looking for, but at least it'll be consistent with the name of the check that is updated when the tests are actually run, so we can then just configure github once.)

@richvdh richvdh merged commit 9d5f1bb into develop Dec 6, 2023
@richvdh richvdh deleted the rav/fix_cypress branch December 6, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants