Skip to content

Don't consider alt_aliases when calculating room name #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 7, 2022

Fixes element-hq/element-web#13887


Here's what your changelog entry will look like:

✨ Features

@t3chguy t3chguy requested a review from a team January 7, 2022 09:48
@t3chguy t3chguy requested a review from a team as a code owner January 7, 2022 09:48
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the tests are unhappy. I think this is actually tested code from memory, so would expect the test failure to be "legitimate" and need fixing.

@t3chguy t3chguy requested review from turt2live and daniellekirkwood and removed request for a team January 10, 2022 09:58
Copy link

@daniellekirkwood daniellekirkwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@t3chguy t3chguy enabled auto-merge (squash) January 10, 2022 12:53
@t3chguy t3chguy merged commit 9b54df7 into develop Jan 10, 2022
@t3chguy t3chguy deleted the t3chguy/fix/13887 branch January 10, 2022 20:42
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jan 17, 2022
* Don't consider alt_aliases when calculating room name ([\matrix-org#2094](matrix-org#2094)). Fixes element-hq/element-web#13887.
* Load room history if necessary when searching for MSC3089 getFileEvent() ([\matrix-org#2066](matrix-org#2066)).
* Add support for MSC3030 `/timestamp_to_event` ([\matrix-org#2072](matrix-org#2072)).
* Stop encrypting redactions as it isn't spec compliant ([\matrix-org#2098](matrix-org#2098)). Fixes element-hq/element-web#20460.
* Fix more function typings relating to key backup ([\matrix-org#2086](matrix-org#2086)).
* Fix timeline search in MSC3089 getFileEvent() ([\matrix-org#2085](matrix-org#2085)).
* Set a `deviceId` for VoIP example and use `const`/`let` ([\matrix-org#2090](matrix-org#2090)). Fixes matrix-org#2083. Contributed by @SimonBrandner.
* Fix incorrect TS return type for secret storage and key backup functions ([\matrix-org#2082](matrix-org#2082)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Room names are calculated incorrectly
3 participants