-
-
Notifications
You must be signed in to change notification settings - Fork 622
Fix timeline jumpiness by setting correct txnId #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c840ca
to
7371f8d
Compare
@t3chguy / @jryans thank you for your review earlier. I have undone my changes to Using the spread operator I can persist all the enumerable properties on the event and add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps sprinkle in some comments on encryption expectations, but otherwise seems good to me. 😄
Fixes element-hq/element-web#16914
Regression introduced by #1655
I incorrectly tried to remove pending events in
updatePendingEvent
when this reconciliation is the responsability of that transaction ID. This PR sets thattxnId
attribute properly and remove the need to explicitely callremovePendingEvent
as the event is now going through the usual timeline flow@t3chguy raised an interesting comment in my previous pull request that is adressed here. The
txnId
is now persisted in storage and re-used at a later stage to ensure idempotency