Skip to content

WIP: End all emoji reactions on VS16 #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: End all emoji reactions on VS16 #522

wants to merge 2 commits into from

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Sep 29, 2020

This does not seem to be compatible with Element at the moment. Element does end some but not all emojis with VS16.

Also, as of today MSC2677 hasn't been merged.

@Half-Shot
Copy link
Contributor

The MSC states:

When sending emoji reactions, the key field should include the colourful variation-16 when applicable.

which seems to line up with:

This does not seem to be compatible with Element at the moment. Element does end some but not all emojis with VS16.

?

@Cadair
Copy link
Collaborator

Cadair commented Sep 30, 2020

Please define "when applicable" 😛

@jaller94
Copy link
Contributor Author

I thought that "when applicable" means emoji characters vs. text characters.
However, it's emoji characters with a text variant vs. those without.

you wouldn't put VS16 on all emojis - only when there's a text variant
~Dave

I will change the PR accordingly.

@jaller94
Copy link
Contributor Author

jaller94 commented Nov 3, 2020

I don't think this needs work unless we discover a tangible bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants