Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Allow user to forget a room, even if they never were a member #2166

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Feb 9, 2022

The spec doesn't say anything about forgetting a room one has never been part of. So remove this part.
Also returns a better message if the user is still a member.

@S7evinK S7evinK requested a review from a team as a code owner February 9, 2022 12:57
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Complement test for this behaviour to ensure we match what Synapse does.

@S7evinK
Copy link
Contributor Author

S7evinK commented Feb 10, 2022

Test is at matrix-org/complement#302, Synapse seems to be happy. Dendrite is unhappy, because this PR isn't merged yet. :)

@S7evinK S7evinK requested a review from kegsay February 10, 2022 08:59
@kegsay kegsay merged commit 432c35a into main Feb 10, 2022
@kegsay kegsay deleted the s7evink/fix-forgetting-rooms branch February 10, 2022 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants