-
Notifications
You must be signed in to change notification settings - Fork 53
Add request builder #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dheid Travis looks good! Give me some time to check the changes, but this looks awesome already. Any open issues that are already solved with this? |
Okay, nothing more to fix or add at the moment. Review can start, @tholu |
@tholu Friendly reminder (Just want to use the builder in one of my projects and waiting for your review) |
@dheid I'll try to get this reviewed (and ideally released on Maven central) by tomorrow evening! |
@tholu Thanks so much!!! |
@dheid Release to Maven Central is on its way and should be there in the next hours. Thank you! |
Hi @tholu !
As announced, I did some enhancements to the Matomo Java Client library:
Old class names and methods will still be there. So most users should not be affected by the update. Nevertheless some things changed and I recommend to use major version 2.
Sorry for the large commit and the unreadable diff. There were some many things to do and I didn't have the time to do it incrementially. Builds are running on my machine, but I cannot use Travis. Perhaps it's a good idea to switch to GitHub Actions soon.
I hope you will merge this pull request! I think the enhancements are worth it.
Best wishes
Daniel