Skip to content

Add request builder #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 9, 2022
Merged

Add request builder #63

merged 9 commits into from
Aug 9, 2022

Conversation

dheid
Copy link
Contributor

@dheid dheid commented Aug 2, 2022

Hi @tholu !

As announced, I did some enhancements to the Matomo Java Client library:

  • I added a request builder to create Matomo requests more easily
  • I renamed everything from Piwik to Matomo
  • I replaced the Glassfish JSON library with Jackson to prevent adding an additional JSON library in Spring projects. Also Jackson is better performing
  • I replaced the multiple maps in the Matomo request class with a Guava Multimap to reduce the lines of code and add custom tracking parameters more easily
  • I added logging with SLF4J, but only on debug level to not flood any logs of consumers
  • I replaced plain setters, getters, constructors and stuff with Lombok to have less bulk code

Old class names and methods will still be there. So most users should not be affected by the update. Nevertheless some things changed and I recommend to use major version 2.

Sorry for the large commit and the unreadable diff. There were some many things to do and I didn't have the time to do it incrementially. Builds are running on my machine, but I cannot use Travis. Perhaps it's a good idea to switch to GitHub Actions soon.

I hope you will merge this pull request! I think the enhancements are worth it.

Best wishes

Daniel

@tholu
Copy link
Collaborator

tholu commented Aug 2, 2022

@dheid Travis looks good! Give me some time to check the changes, but this looks awesome already. Any open issues that are already solved with this?

@dheid
Copy link
Contributor Author

dheid commented Aug 2, 2022

@tholu I browsed through the issues and found one that could be fixed in this context: #58

Added another commit to the pull request

@dheid
Copy link
Contributor Author

dheid commented Aug 2, 2022

@tholu And another one: #41 :-)

@dheid
Copy link
Contributor Author

dheid commented Aug 3, 2022

Okay, nothing more to fix or add at the moment. Review can start, @tholu

@dheid
Copy link
Contributor Author

dheid commented Aug 5, 2022

@tholu Friendly reminder (Just want to use the builder in one of my projects and waiting for your review)

@tholu
Copy link
Collaborator

tholu commented Aug 8, 2022

@dheid I'll try to get this reviewed (and ideally released on Maven central) by tomorrow evening!

@dheid
Copy link
Contributor Author

dheid commented Aug 8, 2022

@tholu Thanks so much!!!

@tholu tholu merged commit 5f27ab2 into matomo-org:master Aug 9, 2022
@tholu
Copy link
Collaborator

tholu commented Aug 9, 2022

@dheid Release to Maven Central is on its way and should be there in the next hours. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants