Redesign PiwikTracker for using AsyncHttpClient singletons #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbertroamsys
commented
May 4, 2021
tholu
approved these changes
Jun 21, 2021
|
Thanks for accepting my changes - the delay wasn't a problem at all ;-). |
|
@norbertroamsys Sure, I'm currently blocked by the migration of Travis CI from .org to .com - needs to be enabled/reconfigured here again. |
|
@norbertroamsys 1.7 should be on the way to Maven Central now. |
|
@norbertroamsys Somehow v1.7 never got published to Maven Central, as I likely forgot to release from staging. I successfully published v1.7 and tagged a release: https://github.com/matomo-org/matomo-java-tracker/releases/tag/v1.7 Should appear in Maven Central tomorrow. |
|
Hi Thomas, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be seen as an improvement of the fixes in #43 for release 1.6.
The former code changes expects that the API user reuses the
PiwikTrackerinstance by making it a singleton.This causes a high probability of a wrong usage and the using application will run again into the really bad situation of resource leaks because threads will be created on each
PiwikTracker.sendRequestAsync()call.Please see discussion #47 for more details!