Dependency cleanup #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's not a good idea. Many of the removed libraries will make building and testing fail. |
tholu
pushed a commit
to tholu/piwik-java-tracker
that referenced
this pull request
Mar 17, 2020
- UriBuilder (jersey-common) replaced and dependency removed - Transitive httpcore dependency removed - Runtime dependencies removed - Plugin versions specified - Java11 compatibility - Compiler Target 1.8
This was referenced Mar 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a series of commits that fix issue #23.
The first commit removes the need for the jersey-common UriBuilder class. The second commit fixes a test for commit 1. The third commit removes the explicit httpcore dependency since it's a transitive dependency of httpclient. The fourth commit removes all the runtime dependencies since they seem to be unused - as far as I can tell and as far as the tests are concerned. The fifth commit removes the jersey-common dependency since the UriBuilder is not used anymore.
The most controversial commit is probably the removal of all the runtime dependencies since I am not sure whether the test cases cover that scenario.