Skip to content

Add Matomo Java Tracker documentation #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Add Matomo Java Tracker documentation #767

merged 9 commits into from
Nov 16, 2023

Conversation

dheid
Copy link
Contributor

@dheid dheid commented Nov 5, 2023

Hi!

I maintain the official Matomo Java Tracker and added a reference / guide on how to use the new version 3.0.6. In addition I allowed myself to edit your README.md and the PHP Composer installation (usually installed system wide).

Would be great if you could include the changes into the documentation. Thank you very much!

Best regards

Daniel

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a rough look through the changes. Haven't done JAVA for quite a long time, so can't say anything about the code examples.

@dheid
Copy link
Contributor Author

dheid commented Nov 14, 2023

@sgiehl Thanks for looking at this PR. I updated it. Is it now mergeable?

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation wise this looks good to me now. Not sure if the changes to the generation script could cause any problems on our server running it. Maybe @tsteur knows that...

@dheid
Copy link
Contributor Author

dheid commented Nov 16, 2023

Okay, I'll remove those changes.

@dheid
Copy link
Contributor Author

dheid commented Nov 16, 2023

And I would like to add a recent feature to the documentation if it's okay?

@sgiehl
Copy link
Member

sgiehl commented Nov 16, 2023

Feel free to add something. Btw. it might not be needed to apply further changes to 2.x and 3.x, as those versions are not maintained any longer.

@dheid
Copy link
Contributor Author

dheid commented Nov 16, 2023

@sgiehl Now it should be okay, please?

@sgiehl sgiehl merged commit 6ae7320 into matomo-org:live Nov 16, 2023
@dheid
Copy link
Contributor Author

dheid commented Nov 16, 2023

Thanks so much!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants