-
Notifications
You must be signed in to change notification settings - Fork 90
Add Matomo Java Tracker documentation #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a rough look through the changes. Haven't done JAVA for quite a long time, so can't say anything about the code examples.
@sgiehl Thanks for looking at this PR. I updated it. Is it now mergeable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation wise this looks good to me now. Not sure if the changes to the generation script could cause any problems on our server running it. Maybe @tsteur knows that...
Okay, I'll remove those changes. |
And I would like to add a recent feature to the documentation if it's okay? |
Feel free to add something. Btw. it might not be needed to apply further changes to |
@sgiehl Now it should be okay, please? |
Thanks so much!!! ❤️ |
Hi!
I maintain the official Matomo Java Tracker and added a reference / guide on how to use the new version 3.0.6. In addition I allowed myself to edit your README.md and the PHP Composer installation (usually installed system wide).
Would be great if you could include the changes into the documentation. Thank you very much!
Best regards
Daniel