Adds caching functionality #86
Conversation
| name: Verify files exist in cache | ||
| command: | | ||
| set -e | ||
| matlab_binary="$HOME/matlab_ci/matlab_root" |
There was a problem hiding this comment.
This seems like the matlab root not the binary?
| RESOLVE_RELEASE_SH: <<include(scripts/resolve-release.sh)>> | ||
| command: | | ||
| eval "$RESOLVE_RELEASE_SH" | ||
| echo "$mpmrelease" > install-metadata.txt |
There was a problem hiding this comment.
Is this writing install-metadata.txt into the user's working directory (where their source code is)? If so, we probably want to put it somewhere else. I think it would be pretty unexpected for the orb to drop files in your source root and more likely for the user to delete or mess with them.
| mpmdir="$tmpdir/mpm" | ||
| matlabcidir="$HOME/matlab_ci" | ||
| mkdir -p "$matlabcidir" | ||
| rootdir="$matlabcidir/matlab_root" |
There was a problem hiding this comment.
It's technically possible for a user to use matlab/install twice in their pipeline to install two different releases of MATLAB, so we probably need to consider getting the release name in this path. Any reason not to install to the standard /usr/local/MATLAB/<release> location used by mpm?
| ${releasestatus} \ | ||
| --products ${PARAM_PRODUCTS} MATLAB | ||
| # Short-circuit if MATLAB & matlab-batch already exist and PARAM_CACHE is true | ||
| if [[ "$PARAM_CACHE" == "1" && -x "$batchdir/matlab-batch$binext" && -x "$rootdir/bin/matlab" ]]; then |
There was a problem hiding this comment.
We shouldn't cache matlab-batch because it is important that we always make sure we're using the latest version of it. It's a fairly small binary, so just downloading it every time isn't bad.
cacheparameter in install step, which cachesMATLABandmatlab-batchin~/matlab-ci/matlab_rootand~/matlab_ci/matlab-batchdirectories, respectively.false.install-metadata.txtfile, which contains the parsed release information and a sorted list of user-specified products.Demo job runs - cache it with circleCI