fix: not throw error when namedGroup is not enabled #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
previously approved these changes
Jun 18, 2020
|
@nicolo-ribaudo test added |
nicolo-ribaudo
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Thanks!
In the following days I will try to investigate with @mathiasbynens why the main branch is failing, then I'll release this in 4.8.0.
|
@nicolo-ribaudo because iu-mappings.js is update by build that is why u only change readme but still fail on test this pr didn't conflict at now, so u didn't need rebase, so can just merge it |
|
if u wanna fix that test error u need change https://github.com/mathiasbynens/regexpu-fixtures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37