Avoid merging if a structure has only one site #4378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an error that occurs when calling
merge_sites
on a structure with only one site. For example:This currently raises the following error:
The root cause is that the distance matrix is a 1×1 array
[[0.0]]
, which leads to a failure inscipy.cluster.hierarchy.linkage
.This PR resolves the issue by skipping the merging step and returning the original structure unchanged when only one site is present.
A unit test is also added to verify this behavior and prevent regressions.
Todos
No more todos.
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: