Skip to content

Replace pybtex with bibtexparser #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 18, 2025
Merged

Replace pybtex with bibtexparser #4361

merged 17 commits into from
Apr 18, 2025

Conversation

DanielYang59
Copy link
Contributor

@DanielYang59 DanielYang59 commented Apr 15, 2025 •
edited
Loading

Summary

  • Replace pybtex with bibtexparser
  • Add bibtexparser lower bound
  • Update requirements.txt (or any other lock file)

DanielYang59 and others added 17 commits April 15, 2025 19:59
@DanielYang59 DanielYang59 marked this pull request as ready for review April 17, 2025 19:49
@DanielYang59
Copy link
Contributor Author

I cannot say I'm a bibtex expert, at least all tests seem to pass (both for cif and StructureNL), anyone experienced with bibtex please free feel to review and comment :D

@DanielYang59 DanielYang59 mentioned this pull request Apr 17, 2025
Closed
5 tasks
@shyuep shyuep merged commit 8794ffa into materialsproject:master Apr 18, 2025
43 checks passed
@DanielYang59 DanielYang59 deleted the replace-pybtex branch April 18, 2025 06:07
@DanielYang59 DanielYang59 mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielYang59 @shyuep