core.Lattice cast pbc to bool (possibly np.bool_)
#4356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
force-pushed
the
lattice-pbc-bool
branch
from
ac187a9 to
04b3035
Compare
benrich37
pushed a commit
to benrich37/pymatgen
that referenced
this pull request
Apr 14, 2025
…roject#4356) * cast to bool * update test
benrich37
pushed a commit
to benrich37/pymatgen
that referenced
this pull request
Apr 14, 2025
…roject#4356) * cast to bool * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
core.Latticecastpbctobool(possiblynp.bool_), to close AseAtomsAdaptor -> Structure -> to(fmt="json") fails #4339