Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to allow pyzeo to work #4315

Merged
merged 15 commits into from
Mar 10, 2025

Conversation

daniel-sintef
Copy link
Contributor

Hi everyone,

Pyzeo is a more maintained version of the cython but has different imports. This small patch allows users to swap out zeo++ with pyzeo.

@shyuep
Copy link
Member

shyuep commented Mar 6, 2025

Great thanks. Can you add / enable some unittests to check that this is working? Thanks.

@mkhorton
Copy link
Member

mkhorton commented Mar 7, 2025

You would also need to add it as an optional dependency, thanks for the edit!

@daniel-sintef
Copy link
Contributor Author

Note that even with the patch one would still need to manually install zeo++, i've added some logic to the test.yaml in the workflow for this, but can't really test it on my end. The tests pass if zeo++ is installed. Historically testing the zeo++ plugin was just skipped for this reason, but maybe it can be automated and included?

@daniel-sintef
Copy link
Contributor Author

@shyuep @mkhorton a gentle reminder to take a look whenever you have time. -Daniel

@shyuep shyuep merged commit 4d9e503 into materialsproject:master Mar 10, 2025
1 check passed
@shyuep
Copy link
Member

shyuep commented Mar 10, 2025

Thanks!

@daniel-sintef
Copy link
Contributor Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants