Fix monty imports, enhance test for Outcar parser to cover uncompressed format
#4068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
DanielYang59
force-pushed
the
test-monty-reverse-read
branch
from
c234535 to
7d2ed7b
Compare
DanielYang59
changed the title
monty fix for reverse readlinemonty fix for reverse_readline
DanielYang59
commented
Nov 8, 2024
DanielYang59
changed the title
monty fix for reverse_readlinemonty imports, enhance test for Outcar parser to cover uncompressed format
DanielYang59
force-pushed
the
test-monty-reverse-read
branch
from
6b44797 to
d41a039
Compare
|
@shyuep I guess this PR has been forgotten, can you please review this? Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
montyfix for reverse readline, close Outcar class returns empty magnetization attribute when parsing OUTCAR file on Windows operating system #4033 and close Issue #4033 appears again: outcar unable to parse magnetization #4237reverse_readlinewith fasterreverse_readfilemontyimports