Skip to content

Don't run issue-metrics on forks #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

ab5424
Copy link
Contributor

@ab5424 ab5424 commented Aug 1, 2024

Summary

Major changes:

  • issue-metrics should not be run on forks because it can't create a new issue on the fork anyway.

@ab5424
Copy link
Contributor Author

ab5424 commented Aug 1, 2024

No idea why the test are failing...

@janosh
Copy link
Member

janosh commented Aug 1, 2024

likely caused by the recent torch==2.4.0 release

unrelated issue but just noticed matgl is not setting a minimum torch version @kenko911

@janosh janosh merged commit b35b99e into materialsproject:master Aug 2, 2024
31 of 33 checks passed
@janosh janosh added github actions Pull requests that update GitHub Actions code dx Developer experience labels Aug 9, 2024
@ab5424 ab5424 deleted the metrics_not_on_fork branch August 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer experience github actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants