Ensure MSONAtoms
is indeed MSONable
when Atoms.info
is loaded with goodies
#3670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3668.
The
Atoms.info
dictionary can be populated with all kinds of goodies that are challenging to deal with from a (de)serialization perspective. Oftentimes, this is from users hacking things intoAtoms.info
. For instance, in #3668, I put aStructure
object in theAtoms.info
dictionary, which then broke things during serialization. In order to ensureMSONAtoms
plays nice with the (de)serialization routines inmonty
, it is better to split off theAtoms.info
metadata into its own entry in the.as_dict()
dictionary that we can sanitize ourselves. That's what I've done in this PR.The following toy example now works in a round-trip fashion: