Skip to content

release.yml add option to publish to TestPyPI #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2023
Merged

release.yml add option to publish to TestPyPI #3375

merged 4 commits into from
Oct 5, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Oct 4, 2023

    def test_egg_sources_txt_is_complete():
        """Check that all source and data files in pymatgen/ are listed in pymatgen.egg-info/SOURCES.txt."""
    
        with open(src_txt_path) as file:
            sources = file.read()
    
        # check that all files listed in SOURCES.txt exist
        for src_file in sources.splitlines():
            assert os.path.exists(src_file), f"{src_file!r} does not exist!"
    
        # check that all files in pymatgen/ are listed in SOURCES.txt
        for ext in ("py", "json", "json.gz", "yaml", "csv"):
            for filepath in glob(f"pymatgen/**/*.{ext}", recursive=True):
                if "/tests/" in filepath or filepath.endswith("dao.py"):
                    continue
                if filepath not in sources:
>                   raise ValueError(
                        f"{filepath} not found in {src_txt_path}. check setup.py package_data for outdated inclusion rules."
                    )
E                   ValueError: pymatgen\alchemy\filters.py not found in pymatgen.egg-info/SOURCES.txt. check setup.py package_data for outdated inclusion rules.

tests\test_pkg.py:29: ValueError

@janosh janosh added tests Issues with or changes to the pymatgen test suite fix Bug fix PRs ci Continuous integration labels Oct 4, 2023
@janosh janosh changed the title Temp fix for test_egg_sources_txt_is_complete failing on pymatgen.alchemy on windows only release.yml add option to publish to TestPyPI Oct 5, 2023
@janosh janosh merged commit 2bfbacd into master Oct 5, 2023
@janosh janosh deleted the fix-ci branch October 5, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration fix Bug fix PRs tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant