Add properties
@property/docstring to IStructure
#3338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #3264, notifying @gpetretto, @janosh.
Two things I think we missed in #3264:
@property
so that we get a docstring for the newIStructure.properties
Structure
from a previous pymatgen version, and then un-pickle it with the new pymatgen version, the__init__
will not be called, so the.properties
instance variable is never set: this will then break code that relies upon it, likeas_dict()
. Luckily, adding the@property
interface allows us to trivially catch this edge case.