Breaking: rename get_ax3d_fig_plt->get_ax3d_fig and get_ax_fig_plt->get_ax_fig plus no longer return plt
#3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably doesn't work with new markdown docs, can't check without network atm
janosh
added
data viz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7fc6bb5 breaking: rename get_ax3d_fig_plt->get_ax3d_fig and stop returning matplotlib.pyplot
cd75674 breaking: same for get_ax_fig_plt->get_ax_fig
0a58b78 remove :class:
SomeObjectfrom doc stringsbf1a65e simplify doc strings: pymatgen.core.(lattice.->'')Lattice
0f42140 blank line before all Args: and Returns: doc string section headers
cbaa100 use dict.setdefault() instead of checking key presence first
74e5f85 doc string indentation and line break fixes
45d18cc fix doc string Returns: sections
62c06f0 define reusable LatticeType and CrystalSystem types
039b4b1 simplify with_local_env_strategy() sg.add_edge() call