Skip to content

Migrate from warnings.catch_warnings(record=True) to pytest.warns() #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2023
Merged

Migrate from warnings.catch_warnings(record=True) to pytest.warns() #3125

merged 8 commits into from
Jul 2, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jul 2, 2023 •
edited
Loading

Reason: more concise + pytest.warns(match='msg') encourages testing warning message for added test precision.

@janosh janosh added tests Issues with or changes to the pymatgen test suite linting Linting and quality assurance labels Jul 2, 2023
@janosh janosh enabled auto-merge (squash) July 2, 2023 15:03
@janosh janosh merged commit e766122 into master Jul 2, 2023
@janosh janosh deleted the test-warnings branch July 2, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linting Linting and quality assurance tests Issues with or changes to the pymatgen test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh