PymatgenTest add auto-used tmp_path fixture (replaces ScratchDir)
#3067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def _tmp_dir(self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None: make all tests run a in a temporary directory accessible via self.tmp_path
janosh
added
tests
janosh
changed the title
tmp_path fixture (replaces ScratchDir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
534af30
PymatgenTestadd@pytest.fixture(autouse=True) def _tmp_dir(self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:a189032 remove many no longer needed
monty.tempfile.ScratchDir(".")@shyuep It's a bit more magical since people who don't look at
PymatgenTestwon't know that their tests now run in a temporary directory by default due to this new fixture. But the code is cleaner now imo and less chance of failing tests leaving behind undeleted files in the repo that littergit status.