Skip to content

Don't require ASE as dependency #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Don't require ASE as dependency #3062

merged 2 commits into from
Jun 12, 2023

Conversation

Andrew-S-Rosen
Copy link
Member

Closes #3061. @JaGeo

@JaGeo
Copy link
Member

JaGeo commented Jun 12, 2023

Thanks!

@shyuep shyuep merged commit c55df74 into materialsproject:master Jun 12, 2023
@Andrew-S-Rosen Andrew-S-Rosen deleted the asefix branch June 12, 2023 21:47
@Andrew-S-Rosen
Copy link
Member Author

No problem. Please let me know if this issue still arises anywhere else!

@janosh
Copy link
Member

janosh commented Jun 13, 2023

Just a heads up that this PR was merged empty and so #3061 isn't actually fixed yet. I'll re-open that issue and re-apply the fix.

@janosh janosh added pkg Package health and distribution related stuff ase Atomic simulation environment fix Bug fix PRs labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ase Atomic simulation environment fix Bug fix PRs pkg Package health and distribution related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ase in optional requirement vs. ase import in pymatgen.core.structure
4 participants