Skip to content

IcohpValue.__str__ don't return None #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2023
Merged

IcohpValue.__str__ don't return None #3052

merged 4 commits into from
Jun 7, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jun 7, 2023

Also use modern f-string syntax.

@janosh janosh added linting Linting and quality assurance housekeeping Moving around or cleaning up old code/files labels Jun 7, 2023
@janosh janosh enabled auto-merge (squash) June 7, 2023 03:51
@janosh janosh disabled auto-merge June 7, 2023 06:46
@janosh janosh merged commit e2b0801 into master Jun 7, 2023
@janosh janosh deleted the fix-IcohpValue-__str__-ret-val branch June 7, 2023 06:46
@janosh
Copy link
Member Author

janosh commented Jun 7, 2023

CI failure caused by legacy MPRester, unrelated to PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
housekeeping Moving around or cleaning up old code/files linting Linting and quality assurance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh