Skip to content

Simplify dict["key"] if "key" in dict else None to dict.get("key") #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Jun 3, 2023

No description provided.

@janosh janosh added the housekeeping Moving around or cleaning up old code/files label Jun 3, 2023
@janosh janosh enabled auto-merge (squash) June 3, 2023 01:18
janosh added 4 commits June 2, 2023 20:13
    def test_pourbaix_mpr_pipeline(self):
        data = self.rester.get_pourbaix_entries(["Zn"])
        pbx = PourbaixDiagram(data, filter_solids=True, conc_dict={"Zn": 1e-8})
        pbx.find_stable_entry(10, 0)

        data = self.rester.get_pourbaix_entries(["Ag", "Te"])
        pbx = PourbaixDiagram(data, filter_solids=True, conc_dict={"Ag": 1e-8, "Te": 1e-8})
>       assert len(pbx.stable_entries) == 29
@janosh janosh merged commit 67ba063 into master Jun 3, 2023
@janosh janosh deleted the simplify-dict-if-else-none branch June 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Moving around or cleaning up old code/files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant